refactor(goods): 移除商品更新页面中的冗余代码

Administrator

2026-06-14 84e8be6264c5f8194067680f7361df029e46892a

 src/main/java/cc/mrbird/febs/mall/service/impl/MallMemberCollectionServiceImpl.java

@@ -1,5 +1,6 @@
package cc.mrbird.febs.mall.service.impl;

import cc.mrbird.febs.common.entity.FebsResponse;
import cc.mrbird.febs.common.exception.FebsException;
import cc.mrbird.febs.common.utils.LoginUserUtil;
import cc.mrbird.febs.mall.dto.AddCollectionDto;
@@ -35,12 +36,12 @@
    private final IApiMallGoodsService apiMallGoodsService;

    @Override
    public void add(AddCollectionDto addCollectionDto) {
    public FebsResponse add(AddCollectionDto addCollectionDto) {
        MallMember member = LoginUserUtil.getLoginUser();

        MallGoods mallgoods = apiMallGoodsService.getById(addCollectionDto.getGoodsId());
        if (mallgoods == null) {
            throw new FebsException("商品不存在");
            throw new FebsException("The product does not exist.");
        }

        LambdaQueryWrapper<MallMemberCollection> queryWrapper = new LambdaQueryWrapper<>();
@@ -48,14 +49,15 @@
        queryWrapper.eq(MallMemberCollection::getGoodsId, addCollectionDto.getGoodsId());
        List<MallMemberCollection> mallMemberCollections = this.baseMapper.selectList(queryWrapper);
        if (CollUtil.isNotEmpty(mallMemberCollections)) {
            throw new FebsException("商品已收藏");
            throw new FebsException("Product has been favorited");
        }

        MallMemberCollection collection = new MallMemberCollection();
        collection.setMemberId(member.getId());
        collection.setGoodsId(addCollectionDto.getGoodsId());

        this.baseMapper.insert(collection);

        return new FebsResponse().success().message("Added to favorites");
    }

    @Override
@@ -76,8 +78,14 @@
    @Override
    public void del(String ids) {
        MallMember member = LoginUserUtil.getLoginUser();
        List<String> idsList = StrUtil.split(ids, ',');
        List<String> goodsIdList = StrUtil.split(ids, ',');

        LambdaQueryWrapper<MallMemberCollection> query = new LambdaQueryWrapper<>();
        query.in(MallMemberCollection::getGoodsId, goodsIdList);
        query.eq(MallMemberCollection::getMemberId, member.getId());
        List<MallMemberCollection> collections = this.baseMapper.selectList(query);

        List<Long> idsList = collections.stream().map(MallMemberCollection::getId).collect(Collectors.toList());
        LambdaQueryWrapper<MallMemberCollection> delQuery = new LambdaQueryWrapper<>();
        delQuery.in(MallMemberCollection::getId, idsList);
        delQuery.eq(MallMemberCollection::getMemberId, member.getId());