refactor(mall): 移除查找商品类别列表中的冗余代码

KKSU

2025-01-23 02b98ce7472cfa06ae48f6bdb4145fc4e34f87af

refactor(mall): 移除查找商品类别列表中的冗余代码

- 删除了 ApiMallGoodsCategoryServiceImpl 中的冗余代码块
- 优化了 findAllCategoryList 方法，提高了代码的可读性和性能

 src/main/java/cc/mrbird/febs/mall/service/impl/ApiMallGoodsCategoryServiceImpl.java

@@ -1,7 +1,6 @@
package cc.mrbird.febs.mall.service.impl;

import cc.mrbird.febs.mall.entity.MallAddressWorld;
import cc.mrbird.febs.mall.entity.MallGoods;
import cc.mrbird.febs.mall.entity.MallGoodsCategory;
import cc.mrbird.febs.mall.mapper.MallAddressWorldMapper;
import cc.mrbird.febs.mall.mapper.MallGoodsCategoryMapper;
@@ -34,22 +33,22 @@
    @Override
    public List<MallGoodsCategoryVo> findAllCategoryList() {
        List<MallGoodsCategoryVo> mallGoodsCategoryVos = this.baseMapper.selectAllCategoryList();
        ArrayList<MallGoodsCategoryVo> objects = new ArrayList<>();
        if(CollUtil.isNotEmpty(mallGoodsCategoryVos)){
            mallGoodsCategoryVos.forEach(item -> {
                Long id = item.getId();
                List<MallGoods> mallGoods = mallGoodsMapper.selectList(
                        new LambdaQueryWrapper<MallGoods>()
                                .select(MallGoods::getId)
                                .eq(MallGoods::getCategoryId, id));
                if(CollUtil.isEmpty(mallGoods)){
                    objects.add(item);
                }
            });
        }
        if(CollUtil.isNotEmpty(objects)){
            mallGoodsCategoryVos.removeAll(objects);
        }
//        ArrayList<MallGoodsCategoryVo> objects = new ArrayList<>();
//        if(CollUtil.isNotEmpty(mallGoodsCategoryVos)){
//            mallGoodsCategoryVos.forEach(item -> {
//                Long id = item.getId();
//                List<MallGoods> mallGoods = mallGoodsMapper.selectList(
//                        new LambdaQueryWrapper<MallGoods>()
//                                .select(MallGoods::getId)
//                                .eq(MallGoods::getCategoryId, id));
//                if(CollUtil.isEmpty(mallGoods)){
//                    objects.add(item);
//                }
//            });
//        }
//        if(CollUtil.isNotEmpty(objects)){
//            mallGoodsCategoryVos.removeAll(objects);
//        }
        return mallGoodsCategoryVos;
    }