Administrator
2026-06-14 5fd317424dbb8b1399e5f28352792b19a0b14919
refactor(mall): 移除商品分类查询中的冗余过滤逻辑

- 注释掉原有的空商品分类过滤代码块
- 简化 findAllCategoryList 方法实现
- 提升代码可读性和维护性
1 files modified
32 ■■■■ changed files
src/main/java/cc/mrbird/febs/mall/service/impl/ApiMallGoodsCategoryServiceImpl.java 32 ●●●● patch | view | raw | blame | history
src/main/java/cc/mrbird/febs/mall/service/impl/ApiMallGoodsCategoryServiceImpl.java
@@ -34,22 +34,22 @@
    @Override
    public List<MallGoodsCategoryVo> findAllCategoryList() {
        List<MallGoodsCategoryVo> mallGoodsCategoryVos = this.baseMapper.selectAllCategoryList();
        ArrayList<MallGoodsCategoryVo> objects = new ArrayList<>();
        if(CollUtil.isNotEmpty(mallGoodsCategoryVos)){
            mallGoodsCategoryVos.forEach(item -> {
                Long id = item.getId();
                List<MallGoods> mallGoods = mallGoodsMapper.selectList(
                        new LambdaQueryWrapper<MallGoods>()
                                .select(MallGoods::getId)
                                .eq(MallGoods::getCategoryId, id));
                if(CollUtil.isEmpty(mallGoods)){
                    objects.add(item);
                }
            });
        }
        if(CollUtil.isNotEmpty(objects)){
            mallGoodsCategoryVos.removeAll(objects);
        }
//        ArrayList<MallGoodsCategoryVo> objects = new ArrayList<>();
//        if(CollUtil.isNotEmpty(mallGoodsCategoryVos)){
//            mallGoodsCategoryVos.forEach(item -> {
//                Long id = item.getId();
//                List<MallGoods> mallGoods = mallGoodsMapper.selectList(
//                        new LambdaQueryWrapper<MallGoods>()
//                                .select(MallGoods::getId)
//                                .eq(MallGoods::getCategoryId, id));
//                if(CollUtil.isEmpty(mallGoods)){
//                    objects.add(item);
//                }
//            });
//        }
//        if(CollUtil.isNotEmpty(objects)){
//            mallGoodsCategoryVos.removeAll(objects);
//        }
        return mallGoodsCategoryVos;
    }