Administrator
2 days ago da3b1c420009a4d80df3e247015b7c100ea99bc4
refactor(mall): 优化票号验证逻辑

- 修改票号不存在时的异常提示信息
- 调整票号验证逻辑,确保票号存在且未核销后才进行后续操作
- 移除冗余代码,提高代码可读性
1 files modified
21 ■■■■ changed files
src/main/java/cc/mrbird/febs/mall/service/impl/HappyActivityServiceImpl.java 21 ●●●● patch | view | raw | blame | history
src/main/java/cc/mrbird/febs/mall/service/impl/HappyActivityServiceImpl.java
@@ -908,7 +908,7 @@
                .last("limit 1")
        );
        if(happyActivityOrderItem == null){
            throw new FebsException("票号异常!");
            throw new FebsException("票号不存在!");
        }
        HappyActivity happyActivity = this.baseMapper.selectById(happyActivityOrderItem.getActivityId());
@@ -944,16 +944,17 @@
                        .eq(HappyActivityOrderItem::getCode, orderItemCode)
                        .last("limit 1")
        );
        if(happyActivityOrderItem != null){
            if(StateUpDownEnum.UP.getCode() == happyActivityOrderItem.getState()){
                throw new FebsException("票号已核销!");
            }
            happyActivityOrderItem.setState(StateUpDownEnum.UP.getCode());
            happyActivityOrderItem.setTransferItemId(memberId);
            happyActivityOrderItemMapper.updateById(happyActivityOrderItem);
            agentProducer.sendCheckActivityItem(happyActivityOrderItem.getOrderId());
        if(happyActivityOrderItem == null){
            throw new FebsException("票号不存在!");
        }
        if(StateUpDownEnum.UP.getCode() == happyActivityOrderItem.getState()){
            throw new FebsException("票号已核销!");
        }
        happyActivityOrderItem.setState(StateUpDownEnum.UP.getCode());
        happyActivityOrderItem.setTransferItemId(memberId);
        happyActivityOrderItemMapper.updateById(happyActivityOrderItem);
        agentProducer.sendCheckActivityItem(happyActivityOrderItem.getOrderId());
        return new FebsResponse().success().message("操作成功");
    }