refactor(mall): 优化商品分类查询逻辑

KKSU

2025-01-08 f36600384327c9152d9cfe24cb1860077c8a7806

refactor(mall): 优化商品分类查询逻辑

- 新增一个空的 ArrayList 对象用于存储需要删除的商品分类
- 遍历商品分类列表，将没有商品的商品分类添加到新列表中
- 最后一次性删除所有不需要的商品分类，减少列表操作次数

 src/main/java/cc/mrbird/febs/mall/service/impl/ApiMallGoodsCategoryServiceImpl.java

@@ -34,6 +34,7 @@
    @Override
    public List<MallGoodsCategoryVo> findAllCategoryList() {
        List<MallGoodsCategoryVo> mallGoodsCategoryVos = this.baseMapper.selectAllCategoryList();
        ArrayList<MallGoodsCategoryVo> objects = new ArrayList<>();
        if(CollUtil.isNotEmpty(mallGoodsCategoryVos)){
            mallGoodsCategoryVos.forEach(item -> {
                Long id = item.getId();
@@ -42,10 +43,13 @@
                                .select(MallGoods::getId)
                                .eq(MallGoods::getCategoryId, id));
                if(CollUtil.isNotEmpty(mallGoods)){
                    mallGoodsCategoryVos.remove(item);
                    objects.add(item);
                }
            });
        }
        if(CollUtil.isNotEmpty(objects)){
            mallGoodsCategoryVos.removeAll(objects);
        }
        return mallGoodsCategoryVos;
    }