From 02b98ce7472cfa06ae48f6bdb4145fc4e34f87af Mon Sep 17 00:00:00 2001
From: KKSU <15274802129@163.com>
Date: Thu, 23 Jan 2025 11:26:38 +0800
Subject: [PATCH] refactor(mall): 移除查找商品类别列表中的冗余代码
---
src/main/java/cc/mrbird/febs/mall/service/impl/ApiMallGoodsCategoryServiceImpl.java | 33 ++++++++++++++++-----------------
1 files changed, 16 insertions(+), 17 deletions(-)
diff --git a/src/main/java/cc/mrbird/febs/mall/service/impl/ApiMallGoodsCategoryServiceImpl.java b/src/main/java/cc/mrbird/febs/mall/service/impl/ApiMallGoodsCategoryServiceImpl.java
index 154044d..0a936d5 100644
--- a/src/main/java/cc/mrbird/febs/mall/service/impl/ApiMallGoodsCategoryServiceImpl.java
+++ b/src/main/java/cc/mrbird/febs/mall/service/impl/ApiMallGoodsCategoryServiceImpl.java
@@ -1,7 +1,6 @@
package cc.mrbird.febs.mall.service.impl;
import cc.mrbird.febs.mall.entity.MallAddressWorld;
-import cc.mrbird.febs.mall.entity.MallGoods;
import cc.mrbird.febs.mall.entity.MallGoodsCategory;
import cc.mrbird.febs.mall.mapper.MallAddressWorldMapper;
import cc.mrbird.febs.mall.mapper.MallGoodsCategoryMapper;
@@ -34,22 +33,22 @@
@Override
public List<MallGoodsCategoryVo> findAllCategoryList() {
List<MallGoodsCategoryVo> mallGoodsCategoryVos = this.baseMapper.selectAllCategoryList();
- ArrayList<MallGoodsCategoryVo> objects = new ArrayList<>();
- if(CollUtil.isNotEmpty(mallGoodsCategoryVos)){
- mallGoodsCategoryVos.forEach(item -> {
- Long id = item.getId();
- List<MallGoods> mallGoods = mallGoodsMapper.selectList(
- new LambdaQueryWrapper<MallGoods>()
- .select(MallGoods::getId)
- .eq(MallGoods::getCategoryId, id));
- if(CollUtil.isEmpty(mallGoods)){
- objects.add(item);
- }
- });
- }
- if(CollUtil.isNotEmpty(objects)){
- mallGoodsCategoryVos.removeAll(objects);
- }
+// ArrayList<MallGoodsCategoryVo> objects = new ArrayList<>();
+// if(CollUtil.isNotEmpty(mallGoodsCategoryVos)){
+// mallGoodsCategoryVos.forEach(item -> {
+// Long id = item.getId();
+// List<MallGoods> mallGoods = mallGoodsMapper.selectList(
+// new LambdaQueryWrapper<MallGoods>()
+// .select(MallGoods::getId)
+// .eq(MallGoods::getCategoryId, id));
+// if(CollUtil.isEmpty(mallGoods)){
+// objects.add(item);
+// }
+// });
+// }
+// if(CollUtil.isNotEmpty(objects)){
+// mallGoodsCategoryVos.removeAll(objects);
+// }
return mallGoodsCategoryVos;
}
--
Gitblit v1.9.1