From 20e0c1036ebc6d558e57644b770b9c9de8bcf383 Mon Sep 17 00:00:00 2001
From: KKSU <15274802129@163.com>
Date: Thu, 23 Jan 2025 14:16:39 +0800
Subject: [PATCH] refactor(mall): 重构商品相关操作的验证逻辑

---
 src/main/java/cc/mrbird/febs/mall/service/impl/ApiMallNewsServiceImpl.java |   19 +++++++++++--------
 1 files changed, 11 insertions(+), 8 deletions(-)

diff --git a/src/main/java/cc/mrbird/febs/mall/service/impl/ApiMallNewsServiceImpl.java b/src/main/java/cc/mrbird/febs/mall/service/impl/ApiMallNewsServiceImpl.java
index 6dc9cff..62900eb 100644
--- a/src/main/java/cc/mrbird/febs/mall/service/impl/ApiMallNewsServiceImpl.java
+++ b/src/main/java/cc/mrbird/febs/mall/service/impl/ApiMallNewsServiceImpl.java
@@ -8,8 +8,8 @@
 import cc.mrbird.febs.mall.service.IApiMallNewsService;
 import cc.mrbird.febs.mall.vo.NewsListVo;
 import cn.hutool.core.collection.CollUtil;
+import cn.hutool.core.util.StrUtil;
 import com.baomidou.mybatisplus.core.conditions.query.LambdaQueryWrapper;
-import com.baomidou.mybatisplus.core.conditions.query.QueryWrapper;
 import com.baomidou.mybatisplus.core.metadata.IPage;
 import com.baomidou.mybatisplus.extension.plugins.pagination.Page;
 import com.baomidou.mybatisplus.extension.service.impl.ServiceImpl;
@@ -17,6 +17,8 @@
 import lombok.extern.slf4j.Slf4j;
 import org.springframework.stereotype.Service;
 
+import java.math.BigDecimal;
+import java.math.RoundingMode;
 import java.util.List;
 
 /**
@@ -60,16 +62,17 @@
 
     @Override
     public FebsResponse findAllBanner() {
-        QueryWrapper<PlatformBanner> queryWrapper = new QueryWrapper<>();
-        queryWrapper.orderByAsc("is_top");
-        queryWrapper.orderByAsc("created_time");
-        List<PlatformBanner> paymentMethodList = platformBannerMapper.selectList(queryWrapper);
+        List<PlatformBanner> paymentMethodList = platformBannerMapper.selectList(
+                new LambdaQueryWrapper<PlatformBanner>()
+                        .orderByAsc(PlatformBanner::getIsTop)
+                        .orderByAsc(PlatformBanner::getCreatedTime)
+        );
         if(CollUtil.isNotEmpty(paymentMethodList)){
             paymentMethodList.forEach(item -> {
-                if("1".equals(item.getIsJump()) && 1 == item.getIsInside()){
+                if("1".equals(item.getIsJump()) && 1 == item.getIsInside() && StrUtil.isNotEmpty(item.getJumpUrl())){
                     String jumpUrl = item.getJumpUrl();
-                    MallActivity mallActivity = mallActivityMapper.selectById(
-                            new LambdaQueryWrapper<MallActivity>().eq(MallActivity::getId, Long.parseLong(jumpUrl)));
+                    MallActivity mallActivity = mallActivityMapper.selectById(Long.parseLong(jumpUrl));
+
                     item.setActivityId(mallActivity.getId());
                 }
             });

--
Gitblit v1.9.1