From 5ecb19a07c10cad36666bab23f14245dc4c10174 Mon Sep 17 00:00:00 2001
From: KKSU <15274802129@163.com>
Date: Wed, 22 Jan 2025 15:02:18 +0800
Subject: [PATCH] refactor(mall): 重构订单发货逻辑

---
 src/main/java/cc/mrbird/febs/mall/service/impl/AdminMallOrderService.java |   27 ++++++++++++++++-----------
 1 files changed, 16 insertions(+), 11 deletions(-)

diff --git a/src/main/java/cc/mrbird/febs/mall/service/impl/AdminMallOrderService.java b/src/main/java/cc/mrbird/febs/mall/service/impl/AdminMallOrderService.java
index 5134332..82a5090 100644
--- a/src/main/java/cc/mrbird/febs/mall/service/impl/AdminMallOrderService.java
+++ b/src/main/java/cc/mrbird/febs/mall/service/impl/AdminMallOrderService.java
@@ -6,6 +6,7 @@
 import cc.mrbird.febs.common.enumerates.MoneyFlowTypeEnum;
 import cc.mrbird.febs.common.enumerates.OrderDeliveryStateEnum;
 import cc.mrbird.febs.common.enumerates.OrderStatusEnum;
+import cc.mrbird.febs.common.utils.ValidateEntityUtils;
 import cc.mrbird.febs.mall.dto.*;
 import cc.mrbird.febs.mall.entity.*;
 import cc.mrbird.febs.mall.mapper.*;
@@ -104,17 +105,21 @@
     @Override
     public FebsResponse deliverGoods(DeliverGoodsDto deliverGoodsDto) {
         MallOrderInfo mallOrderInfo = mallOrderInfoMapper.selectById(deliverGoodsDto.getId());
-        if(ObjectUtil.isEmpty(mallOrderInfo)){
-            return new FebsResponse().fail().message("订单不存在,刷新后重试");
-        }
-        Integer status = mallOrderInfo.getStatus();
-        if(2 != status){
-            return new FebsResponse().fail().message("订单不是待发货状态");
-        }
-        Integer deliveryType = mallOrderInfo.getDeliveryType();
-        if(2 != deliveryType){
-            return new FebsResponse().fail().message("订单的配送方式不是快递");
-        }
+        ValidateEntityUtils.ensureColumnValid(deliverGoodsDto.getId(), MallOrderInfo::getId, mallOrderInfoMapper::selectOne, "订单{}不存在");
+//        if(ObjectUtil.isEmpty(mallOrderInfo)){
+//            return new FebsResponse().fail().message("订单不存在,刷新后重试");
+//        }
+        ValidateEntityUtils.ensureEqual(mallOrderInfo.getStatus(), OrderStatusEnum.WAIT_SHIPPING.getValue(), "订单状态不是待发货状态");
+//        Integer status = mallOrderInfo.getStatus();
+//        if(2 != status){
+//            return new FebsResponse().fail().message("订单不是待发货状态");
+//        }
+
+        ValidateEntityUtils.ensureEqual(mallOrderInfo.getDeliveryType(), 2, "订单的配送方式不是快递");
+//        Integer deliveryType = mallOrderInfo.getDeliveryType();
+//        if(2 != deliveryType){
+//            return new FebsResponse().fail().message("订单的配送方式不是快递");
+//        }
 //        String expressNo = deliverGoodsDto.getExpressNo();
 //        if(StrUtil.isEmpty(expressNo)){
 //            return new FebsResponse().fail().message("请输入物流单号");

--
Gitblit v1.9.1