From 84e8be6264c5f8194067680f7361df029e46892a Mon Sep 17 00:00:00 2001
From: Administrator <15274802129@163.com>
Date: Sun, 14 Jun 2026 17:15:38 +0800
Subject: [PATCH] refactor(goods): 移除商品更新页面中的冗余代码

---
 src/main/java/cc/mrbird/febs/mall/service/impl/MallMemberCollectionServiceImpl.java |   32 +++++++++++++++++++++++++++++---
 1 files changed, 29 insertions(+), 3 deletions(-)

diff --git a/src/main/java/cc/mrbird/febs/mall/service/impl/MallMemberCollectionServiceImpl.java b/src/main/java/cc/mrbird/febs/mall/service/impl/MallMemberCollectionServiceImpl.java
index a70cb57..817983a 100644
--- a/src/main/java/cc/mrbird/febs/mall/service/impl/MallMemberCollectionServiceImpl.java
+++ b/src/main/java/cc/mrbird/febs/mall/service/impl/MallMemberCollectionServiceImpl.java
@@ -1,11 +1,15 @@
 package cc.mrbird.febs.mall.service.impl;
 
+import cc.mrbird.febs.common.entity.FebsResponse;
+import cc.mrbird.febs.common.exception.FebsException;
 import cc.mrbird.febs.common.utils.LoginUserUtil;
 import cc.mrbird.febs.mall.dto.AddCollectionDto;
 import cc.mrbird.febs.mall.dto.MemberCollectionListDto;
+import cc.mrbird.febs.mall.entity.MallGoods;
 import cc.mrbird.febs.mall.entity.MallMember;
 import cc.mrbird.febs.mall.entity.MallMemberCollection;
 import cc.mrbird.febs.mall.mapper.MallMemberCollectionMapper;
+import cc.mrbird.febs.mall.service.IApiMallGoodsService;
 import cc.mrbird.febs.mall.service.IMallMemberCollectionService;
 import cc.mrbird.febs.mall.vo.AddCollectionVo;
 import cc.mrbird.febs.mall.vo.CollectionListVo;
@@ -29,15 +33,31 @@
 @RequiredArgsConstructor
 public class MallMemberCollectionServiceImpl extends ServiceImpl<MallMemberCollectionMapper, MallMemberCollection> implements IMallMemberCollectionService {
 
+    private final IApiMallGoodsService apiMallGoodsService;
+
     @Override
-    public void add(AddCollectionDto addCollectionDto) {
+    public FebsResponse add(AddCollectionDto addCollectionDto) {
         MallMember member = LoginUserUtil.getLoginUser();
+
+        MallGoods mallgoods = apiMallGoodsService.getById(addCollectionDto.getGoodsId());
+        if (mallgoods == null) {
+            throw new FebsException("The product does not exist.");
+        }
+
+        LambdaQueryWrapper<MallMemberCollection> queryWrapper = new LambdaQueryWrapper<>();
+        queryWrapper.eq(MallMemberCollection::getMemberId, member.getId());
+        queryWrapper.eq(MallMemberCollection::getGoodsId, addCollectionDto.getGoodsId());
+        List<MallMemberCollection> mallMemberCollections = this.baseMapper.selectList(queryWrapper);
+        if (CollUtil.isNotEmpty(mallMemberCollections)) {
+            throw new FebsException("Product has been favorited");
+        }
 
         MallMemberCollection collection = new MallMemberCollection();
         collection.setMemberId(member.getId());
         collection.setGoodsId(addCollectionDto.getGoodsId());
-
         this.baseMapper.insert(collection);
+
+        return new FebsResponse().success().message("Added to favorites");
     }
 
     @Override
@@ -58,8 +78,14 @@
     @Override
     public void del(String ids) {
         MallMember member = LoginUserUtil.getLoginUser();
-        List<String> idsList = StrUtil.split(ids, ',');
+        List<String> goodsIdList = StrUtil.split(ids, ',');
 
+        LambdaQueryWrapper<MallMemberCollection> query = new LambdaQueryWrapper<>();
+        query.in(MallMemberCollection::getGoodsId, goodsIdList);
+        query.eq(MallMemberCollection::getMemberId, member.getId());
+        List<MallMemberCollection> collections = this.baseMapper.selectList(query);
+
+        List<Long> idsList = collections.stream().map(MallMemberCollection::getId).collect(Collectors.toList());
         LambdaQueryWrapper<MallMemberCollection> delQuery = new LambdaQueryWrapper<>();
         delQuery.in(MallMemberCollection::getId, idsList);
         delQuery.eq(MallMemberCollection::getMemberId, member.getId());

--
Gitblit v1.9.1