From e5f2d62c6cc448c217ad5c87f189d8283239065b Mon Sep 17 00:00:00 2001 From: KKSU <15274802129@163.com> Date: Wed, 08 Jan 2025 14:22:21 +0800 Subject: [PATCH] refactor(mall): 优化 ApiMallNewsServiceImpl 中的代码 - 移除了未使用的 QueryWrapper 导入 - 使用 LambdaQueryWrapper 替代 QueryWrapper 进行查询 - 简化了 mallActivityMapper.selectById 的调用 --- src/main/java/cc/mrbird/febs/mall/service/impl/AdminMallGoodsCategoryService.java | 107 +++++++++++++++++++++++++++++++++++++++++++++++++++++ 1 files changed, 107 insertions(+), 0 deletions(-) diff --git a/src/main/java/cc/mrbird/febs/mall/service/impl/AdminMallGoodsCategoryService.java b/src/main/java/cc/mrbird/febs/mall/service/impl/AdminMallGoodsCategoryService.java index 0ebe802..5d5ff09 100644 --- a/src/main/java/cc/mrbird/febs/mall/service/impl/AdminMallGoodsCategoryService.java +++ b/src/main/java/cc/mrbird/febs/mall/service/impl/AdminMallGoodsCategoryService.java @@ -2,8 +2,14 @@ import cc.mrbird.febs.common.entity.FebsResponse; import cc.mrbird.febs.common.entity.QueryRequest; +import cc.mrbird.febs.mall.entity.MallGoods; import cc.mrbird.febs.mall.entity.MallGoodsCategory; +import cc.mrbird.febs.mall.entity.MallStore; +import cc.mrbird.febs.mall.entity.MallStoreItem; import cc.mrbird.febs.mall.mapper.MallGoodsCategoryMapper; +import cc.mrbird.febs.mall.mapper.MallGoodsMapper; +import cc.mrbird.febs.mall.mapper.MallStoreItemMapper; +import cc.mrbird.febs.mall.mapper.MallStoreMapper; import cc.mrbird.febs.mall.service.IAdminMallGoodsCategoryService; import cc.mrbird.febs.mall.vo.AdminMallGoodsCategoryTreeVo; import cc.mrbird.febs.mall.vo.AdminMallGoodsCategoryVo; @@ -16,15 +22,21 @@ import lombok.RequiredArgsConstructor; import lombok.extern.slf4j.Slf4j; import org.springframework.stereotype.Service; +import org.springframework.transaction.annotation.Transactional; import java.util.List; @Slf4j @Service @RequiredArgsConstructor +@Transactional public class AdminMallGoodsCategoryService extends ServiceImpl<MallGoodsCategoryMapper, MallGoodsCategory> implements IAdminMallGoodsCategoryService { private final MallGoodsCategoryMapper mallGoodsCategoryMapper; + + private final MallGoodsMapper mallGoodsMapper; + private final MallStoreMapper mallStoreMapper; + private final MallStoreItemMapper mallStoreItemMapper; @Override public IPage<MallGoodsCategory> getCategoryList(MallGoodsCategory mallGoodsCategory, QueryRequest request) { @@ -51,6 +63,7 @@ MallGoodsCategory goodsCategory = new MallGoodsCategory(); goodsCategory.setName(name); + goodsCategory.setImage(mallGoodsCategory.getImage()); if(ObjectUtil.isNotEmpty(mallGoodsCategory.getParentId())){ Long parentId = mallGoodsCategory.getParentId(); MallGoodsCategory mallGoodsCategoryParent = mallGoodsCategoryMapper.selectById(parentId); @@ -65,6 +78,7 @@ goodsCategory.setParentId(0L); goodsCategory.setIsRecommend(mallGoodsCategory.getIsRecommend()); } + goodsCategory.setIndexNum(mallGoodsCategory.getIndexNum()); mallGoodsCategoryMapper.insert(goodsCategory); return new FebsResponse().success(); } @@ -101,6 +115,8 @@ Long id = mallGoodsCategoryParam.getId(); MallGoodsCategory mallGoodsCategory = mallGoodsCategoryMapper.selectById(id); mallGoodsCategory.setName(mallGoodsCategoryParam.getName()); + mallGoodsCategory.setImage(mallGoodsCategoryParam.getImage()); + mallGoodsCategory.setIndexNum(mallGoodsCategoryParam.getIndexNum()); if(ObjectUtil.isNotEmpty(mallGoodsCategoryParam.getParentId())){ Long parentId = mallGoodsCategoryParam.getParentId(); MallGoodsCategory mallGoodsCategoryParent = mallGoodsCategoryMapper.selectById(parentId); @@ -120,4 +136,95 @@ return new FebsResponse().success(); } + @Override + public FebsResponse delCategary(Long id) { + MallGoodsCategory mallGoodsCategory = mallGoodsCategoryMapper.selectById(id); + if(ObjectUtil.isEmpty(mallGoodsCategory)){ + return new FebsResponse().fail().message("系统繁忙,请刷新页面重试"); + } + List<MallGoodsCategory> childCategarys = mallGoodsCategoryMapper.selectChildCategaryById(id); + if(CollUtil.isNotEmpty(childCategarys)){ + for(MallGoodsCategory childCategary : childCategarys){ + Long childCategaryId = childCategary.getId(); + List<MallGoods> mallChildGoods = mallGoodsMapper.selectMallGoodsByCategaryId(childCategaryId); + if(CollUtil.isNotEmpty(mallChildGoods)){ + return new FebsResponse().fail().message("该分类下的子类【"+childCategary.getName()+"】还有商品,请先删除商品或者修改商品分类"); + } + } + } + + if(CollUtil.isNotEmpty(childCategarys)){ + return new FebsResponse().fail().message("该分类下还有子类,请先删除子类"); + } + + List<MallGoods> mallGoods = mallGoodsMapper.selectMallGoodsByCategaryId(id); + if(CollUtil.isNotEmpty(mallGoods)){ + return new FebsResponse().fail().message("该分类下还有商品,请先删除商品或者修改商品分类"); + } + mallGoodsCategoryMapper.deleteById(mallGoodsCategory); + return new FebsResponse().success(); + } + + @Override + public List<AdminMallGoodsCategoryTreeVo> getAllCategorys() { + List<AdminMallGoodsCategoryTreeVo> adminMallGoodsCategoryTreeVos = mallGoodsCategoryMapper.getAllCategorys(); + return adminMallGoodsCategoryTreeVos; + } + + @Override + public IPage<MallStore> storeList(MallStore mallStore, QueryRequest request) { + Page<MallStore> page = new Page<>(request.getPageNum(), request.getPageSize()); + IPage<MallStore> mallStoreIPage = mallGoodsCategoryMapper.selectStoreListInPage(page, mallStore); + return mallStoreIPage; + } + + @Override + public FebsResponse addStore(MallStore mallStore) { + mallStoreMapper.insert(mallStore); + return new FebsResponse().success(); + } + + @Override + public FebsResponse updateStore(MallStore mallStore) { + mallStoreMapper.updateById(mallStore); + return new FebsResponse().success(); + } + + @Override + public FebsResponse delStore(Long id) { + mallStoreMapper.deleteById(id); + return new FebsResponse().success(); + } + + @Override + public IPage<MallStoreItem> storeItemList(MallStoreItem mallStoreItem, QueryRequest request) { + Page<MallStoreItem> page = new Page<>(request.getPageNum(), request.getPageSize()); + IPage<MallStoreItem> mallStoreItemIPage = mallGoodsCategoryMapper.selectStoreItemListInPage(page, mallStoreItem); + return mallStoreItemIPage; + } + + @Override + public List<MallStore> getStore() { + List<MallStore> mallStores = mallGoodsCategoryMapper.getStore(); + return mallStores; + } + + @Override + public FebsResponse addStoreItem(MallStoreItem mallStoreItem) { + mallStoreItemMapper.insert(mallStoreItem); + return new FebsResponse().success(); + } + + @Override + public FebsResponse updateStoreItem(MallStoreItem mallStoreItem) { + mallStoreItemMapper.updateById(mallStoreItem); + return new FebsResponse().success(); + } + + @Override + public FebsResponse delStoreItem(Long id) { + mallStoreItemMapper.deleteById(id); + return new FebsResponse().success(); + } + } -- Gitblit v1.9.1