From e5f2d62c6cc448c217ad5c87f189d8283239065b Mon Sep 17 00:00:00 2001 From: KKSU <15274802129@163.com> Date: Wed, 08 Jan 2025 14:22:21 +0800 Subject: [PATCH] refactor(mall): 优化 ApiMallNewsServiceImpl 中的代码 - 移除了未使用的 QueryWrapper 导入 - 使用 LambdaQueryWrapper 替代 QueryWrapper 进行查询 - 简化了 mallActivityMapper.selectById 的调用 --- src/main/java/cc/mrbird/febs/mall/service/impl/ApiMallGoodsCategoryServiceImpl.java | 8 ++++++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/main/java/cc/mrbird/febs/mall/service/impl/ApiMallGoodsCategoryServiceImpl.java b/src/main/java/cc/mrbird/febs/mall/service/impl/ApiMallGoodsCategoryServiceImpl.java index 3cf8985..154044d 100644 --- a/src/main/java/cc/mrbird/febs/mall/service/impl/ApiMallGoodsCategoryServiceImpl.java +++ b/src/main/java/cc/mrbird/febs/mall/service/impl/ApiMallGoodsCategoryServiceImpl.java @@ -34,6 +34,7 @@ @Override public List<MallGoodsCategoryVo> findAllCategoryList() { List<MallGoodsCategoryVo> mallGoodsCategoryVos = this.baseMapper.selectAllCategoryList(); + ArrayList<MallGoodsCategoryVo> objects = new ArrayList<>(); if(CollUtil.isNotEmpty(mallGoodsCategoryVos)){ mallGoodsCategoryVos.forEach(item -> { Long id = item.getId(); @@ -41,11 +42,14 @@ new LambdaQueryWrapper<MallGoods>() .select(MallGoods::getId) .eq(MallGoods::getCategoryId, id)); - if(CollUtil.isNotEmpty(mallGoods)){ - mallGoodsCategoryVos.remove(item); + if(CollUtil.isEmpty(mallGoods)){ + objects.add(item); } }); } + if(CollUtil.isNotEmpty(objects)){ + mallGoodsCategoryVos.removeAll(objects); + } return mallGoodsCategoryVos; } -- Gitblit v1.9.1