From e5f2d62c6cc448c217ad5c87f189d8283239065b Mon Sep 17 00:00:00 2001
From: KKSU <15274802129@163.com>
Date: Wed, 08 Jan 2025 14:22:21 +0800
Subject: [PATCH] refactor(mall): 优化 ApiMallNewsServiceImpl 中的代码 - 移除了未使用的 QueryWrapper 导入 - 使用 LambdaQueryWrapper 替代 QueryWrapper 进行查询 - 简化了 mallActivityMapper.selectById 的调用

---
 src/main/java/cc/mrbird/febs/mall/service/impl/ApiMallNewsServiceImpl.java |   13 ++++++-------
 1 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/src/main/java/cc/mrbird/febs/mall/service/impl/ApiMallNewsServiceImpl.java b/src/main/java/cc/mrbird/febs/mall/service/impl/ApiMallNewsServiceImpl.java
index 6dc9cff..8ed4949 100644
--- a/src/main/java/cc/mrbird/febs/mall/service/impl/ApiMallNewsServiceImpl.java
+++ b/src/main/java/cc/mrbird/febs/mall/service/impl/ApiMallNewsServiceImpl.java
@@ -9,7 +9,6 @@
 import cc.mrbird.febs.mall.vo.NewsListVo;
 import cn.hutool.core.collection.CollUtil;
 import com.baomidou.mybatisplus.core.conditions.query.LambdaQueryWrapper;
-import com.baomidou.mybatisplus.core.conditions.query.QueryWrapper;
 import com.baomidou.mybatisplus.core.metadata.IPage;
 import com.baomidou.mybatisplus.extension.plugins.pagination.Page;
 import com.baomidou.mybatisplus.extension.service.impl.ServiceImpl;
@@ -60,16 +59,16 @@
 
     @Override
     public FebsResponse findAllBanner() {
-        QueryWrapper<PlatformBanner> queryWrapper = new QueryWrapper<>();
-        queryWrapper.orderByAsc("is_top");
-        queryWrapper.orderByAsc("created_time");
-        List<PlatformBanner> paymentMethodList = platformBannerMapper.selectList(queryWrapper);
+        List<PlatformBanner> paymentMethodList = platformBannerMapper.selectList(
+                new LambdaQueryWrapper<PlatformBanner>()
+                        .orderByAsc(PlatformBanner::getIsTop)
+                        .orderByAsc(PlatformBanner::getCreatedTime)
+        );
         if(CollUtil.isNotEmpty(paymentMethodList)){
             paymentMethodList.forEach(item -> {
                 if("1".equals(item.getIsJump()) && 1 == item.getIsInside()){
                     String jumpUrl = item.getJumpUrl();
-                    MallActivity mallActivity = mallActivityMapper.selectById(
-                            new LambdaQueryWrapper<MallActivity>().eq(MallActivity::getId, Long.parseLong(jumpUrl)));
+                    MallActivity mallActivity = mallActivityMapper.selectById(Long.parseLong(jumpUrl));
                     item.setActivityId(mallActivity.getId());
                 }
             });

--
Gitblit v1.9.1